Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuttx/crypto: export asynchronous calling process #13696

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

ThePassionate
Copy link

@ThePassionate ThePassionate commented Sep 27, 2024

Summary

  1. The crypto driver implements the poll interfaces
  2. Provides a new cmd to obtain asynchronous results
  3. Adds krp flags to indicate that this operation is an asynchronous operation
    The above new functions can be used to implement the asynchronous call function of the crypto driver.
    Currently, only asymmetric encryption functions are used because they generally take a long time.

Impact

N/A

Testing

ci & add new crypto testcase apache/nuttx-apps#2616

@github-actions github-actions bot added Area: Crypto Size: M The size of the change in this PR is medium labels Sep 27, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 27, 2024

[Experimental Bot, please feedback here]

This PR appears to mostly meet the NuttX requirements, but is missing some key information:

Strengths:

  • Summary: Clearly outlines the "why," "what," and "how" of the changes. The reference to the NuttX Apps PR is good.
  • Testing: Mentions CI and a related NuttX Apps PR with a test case, which is a good start.

Areas for Improvement:

  • Impact: "N/A" is too vague. While some sections might truly have no impact, you need to explicitly state that for each one. For example:
    • Impact on user: NO - No user-facing API changes.
    • Impact on build: MAYBE - If the new cmd introduces new build dependencies, describe them. Otherwise, state NO.
    • Impact on hardware: NO - (Assuming this is purely software-based)
    • Impact on documentation: YES - Needs updates to describe the new cmd and asynchronous usage of the crypto driver.
    • Impact on security: Potentially YES - Asynchronous crypto operations can have security implications. Carefully analyze and document any potential risks or considerations.
    • Impact on compatibility: NO - (Assuming no breaking changes)
  • Testing:
    • Be specific: Mention the specific CI environments (OS, architectures) used.
    • Target details: Provide more details about the target(s) used for testing beyond just "arch." Include the specific board and configurations.
    • Testing logs: The PR should include actual testing logs, not placeholders.

Recommendation:

Revise the PR description to address the missing information. Being thorough and explicit, especially in the "Impact" and "Testing" sections, will make it easier for reviewers to evaluate the PR.

@xiaoxiang781216 xiaoxiang781216 merged commit 5b1d910 into apache:master Sep 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Crypto Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants